Re: [Libguestfs] [PATCH libnbd 1/4] lib: Move nbd_aio_is_* function impls to separate source file.
On Wed, Jun 05, 2019 at 09:25:04AM -0500, Eric Blake wrote:
On 6/5/19 6:15 AM, Richard W.M. Jones wrote:
> Simple code motion.
> ---
> lib/Makefile.am | 1 +
> lib/aio.c | 78 -----------------------------------
> lib/is-state.c | 105 ++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 106 insertions(+), 78 deletions(-)
>
> +++ b/lib/is-state.c
> @@ -0,0 +1,105 @@
> +#include <config.h>
> +
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <stdbool.h>
> +#include <errno.h>
> +#include <inttypes.h>
Do you really need all of these? At least errno.h looks spurious after
a quick glance.
No, over-eager copy and paste. I'll remove the unnecessary ones
before I push it.
ACK.
Thanks, Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org