Re: [Libguestfs] [PATCH 2/2] v2v: allow alternative directories for distributions
On Wednesday, 6 February 2019 14:11:41 CET Tomáš Golembiovský wrote:
> > + * Note that the call may succeed whithout copying any
file at all. This may
> > + * happen when the source subdirectory exists but is empty or when [filter]
> > + * function is too strict to allow any of the files.
>
> Not sure why copy_from_virtio_win should allow an empty list as srcdirs.
> IMHO it seems better to have it error out on an empty list.
>
This is not what I am trying to say there.
I was not commenting on that phrasing, but on the actual behaviour.
copy_from_virtio_win can be called with srcdirs as empty list, and in
that case it will do nothing: IMHO this situation is not a valid one.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)