Re: [Libguestfs] [PATCH virt-v2v 0/3] tests: Add a phony Fedora image for testing

On 06/08/22 18:48, Richard W.M. Jones wrote: > When we split virt-v2v from libguestfs many moons ago, I copied the > test-data/ subdirectory over. I didn't modify it much, and it > contains much test data that is irrelevant to virt-v2v. (This change > does _not_ clean up any of that ...) However we did use the phony > Windows image (test-data/phony-guests/windows.img) to do a semblance > of testing Windows conversions, or as much as can be done without > having the proprietary operating system itself around. > > We never used any of the Linux images, and in fact (before this > change) they could not be used. Ah, indeed; for the LUKS-on-LV stuff, I synched "test-data/phony-guests/make-fedora-img.pl" from libguestfs and guestfs-tools (commits 8f2bbc3d50d8 and 27da4b0c4991), but didn't touch virt-v2v's copy. There was no need, and even prior differences existed. ... Indeed, libguestfs commit 0b223a287711 ("test-data: Replace deprecated luks_open with cryptsetup_open.", 2021-05-27) had not been ported to virt-v2v's copy.

> They simply don't appear close enough > to a real guest to work with virt-v2v. In particular they lack > installed kernels, modules, bootloader config and the program needed > to rebuild the initramfs. > > This change fixes the Fedora image(s) so they can be used for testing, > and adds conversion of those to the testsuite. > > I already pushed the first commit in this series since it was a big > binary blob update to the phony Fedora RPM database that was not > reviewable: > > https://github.com/libguestfs/virt-v2v/commit/0d1b2ec1b733db1ca0bebf2e4a9... > > Rich. > > Thanks Laszlo