Re: [Libguestfs] [PATCH] Fix broken qemu <= 0.10 which randomly adds a CD-ROM device to the appliance
On Thu, Jul 30, 2009 at 12:23:06PM +0100, Matthew Booth wrote:
On 30/07/09 11:20, Richard W.M. Jones wrote:
> Unfortunately we don't know this .. We expose the full qemu command
> line via http://libguestfs.org/guestfs.3.html#guestfs_config .
Ok, tackling this from the other end: What's the list_devices use case
that this breaks?
The one where we add a squashfs as the "last" device, and then get
that device's real name from inside the guest using $g->list_devices()
using whatever the Perl syntax was for getting the last element in a
list.
A more robust way to do this is to use ISO images and volume IDs ...
Anyhow I still can't see how it's useful either for qemu to be adding
random unrequested devices, or to return devices with no media in them
from guestfs_list_devices, and quite rightly the tests were getting
confused when this happened.
Rich.
--
Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://et.redhat.com/~rjones/libguestfs/
See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html