Re: [Libguestfs] [PATCH libguestfs 2/5] guestfish: write --help to stdout, use gnulib's progname module

Also, it is good policy, IMHO, to make it so a program works the same way no matter where the actual binary happens to be located in a file system hierarchy.

>> + enum { HELP_OPTION = CHAR_MAX + 1 }; >> + >> static const char *options = "a:Df:h::im:nrv?Vx"; >> static const struct option long_options[] = { >> { "add", 1, 0, 'a' }, >> { "cmd-help", 2, 0, 'h' }, >> { "file", 1, 0, 'f' }, >> - { "help", 0, 0, '?' }, >> + { "help", 0, 0, HELP_OPTION }, > > I'm unclear on why we do this - what's wrong with using '?'? So that we can distinguish getop-diagnosed failure (where it returns '?') from --help.