Re: [Libguestfs] [PATCH nbdkit] vddk: Relax threading model and enable multi-conn.
On Wed, Aug 05, 2020 at 08:12:26AM -0500, Eric Blake wrote:
On 8/5/20 7:48 AM, Richard W.M. Jones wrote:
>See comment in code and
>https://www.redhat.com/archives/libguestfs/2020-August/msg00023.html
>---
> plugins/vddk/vddk.c | 32 ++++++++++++++++++++++++++++----
> 1 file changed, 28 insertions(+), 4 deletions(-)
I'll have to trust your testing, but code-wise, this looks safe.
I'm in a bit two minds about this one. It appears safe. OTOH it's
somewhat risky in theory, and it doesn't give us very much performance
improvement.
Let's discuss alternate implementations with Nir in the other thread.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html