Re: [Libguestfs] [PATCH nbdkit 2/3] configure: Add --disable-linker-script flag
On 04/07/22 11:37, Richard W.M. Jones wrote:
I have split this into three patches in my local copy, but ...
On Thu, Apr 07, 2022 at 11:20:47AM +0200, Laszlo Ersek wrote:
> The second patch should be related to libfuzzer. It should contain hunks
> #2 and #6. It is also a refactoring. Notably though, the comment in hunk
> #2 should *not* refer to ASAN, only to libfuzzer.
in the second patch I just copied the existing message. I think it's
OK to keep the ASAN reference since libFuzzer separately recommends
using ASAN (https://www.llvm.org/docs/LibFuzzer.html#fuzzer-usage).
Fair enough, thank you!
Laszlo
> Basically we have three separate reasons for disabling the linker
script
> (building on FreeBSD, using libfuzzer, using clang+ASAN). The patches
> should reflect that, in my opinion.
Thanks,
Rich.