Re: [Libguestfs] [PATCH 03/11] customize: fix windows firstboot script
On Fri, May 13, 2016 at 10:48:25AM +0200, Pino Toscano wrote:
On Friday 13 May 2016 10:36:10 Roman Kagan wrote:
> I think the only controversial item is whether to move them to
> scripts_done on success only or regardless of the status: there are pros
> and cons either way.
Moving a script to scripts_done only after its execution ended means
that scripts which cause a reboot will be executed over and over. See
rhbz#1159651 and commit f8ed15462fbb03c5b19972361f2a2e6fed4c5f02.
Indeed this outweighs the pros of the alternative.
Roman.