Re: [Libguestfs] [PATCH nbdkit 0/2] server: Avoid modifying argv by saving keys in a list and freeing on exit.
On Tue, Feb 18, 2020 at 10:52:19AM +0000, Richard W.M. Jones wrote:
Unfortunately you cannot restore argv by setting *p = '='
:-(
The reason is we advertize that plugins are allowed to save they
‘const char *key’ pointer passed to them in .config, but assigning
*p = '=' changes the key string from "key" back to
"key=value".
Surprisingly only test-eval.sh actually broke, but other plugins are
undoubtedly affected.
Most plugins only compare key to some string, but the eval plugin
actually saves the key which is why it fails.
I have pushed the revert commit (part 1).
Rich.
My alternate fix is fairly horrible, but passes all the tests and
valgrind.
Rich.
_______________________________________________
Libguestfs mailing list
Libguestfs(a)redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW