Re: [Libguestfs] [libnbd PATCH v2 04/12] api: Add nbd_set_request_meta_context()

On 09/01/22 22:46, Richard W.M. Jones wrote: > On Thu, Sep 01, 2022 at 03:38:34PM -0500, Eric Blake wrote: >> On Thu, Sep 01, 2022 at 05:29:21PM +0100, Richard W.M. Jones wrote: >>> On Wed, Aug 31, 2022 at 09:39:20AM -0500, Eric Blake wrote: >>>> Add a new control knob nbd_set_request_meta_context(), modeled after >>>> the existing nbd_set_request_structured_replies(), to make it possible >>>> to skip the NBD_OPT_SET_META_CONTEXT half of the two-command sequence >>>> currently performed in nbd_opt_go() and nbd_opt_info(). Also add a >>>> counterpart nbd_get_request_meta_context() for symmetry. >>>> >>> >>> This really needs an example. >> >> Will do. Sounds like I have enough incremental things to improve that >> it will be worth a v3 series, although I'll continue to let more >> reviews come on in the rest of the series before I post that. > > I did look at all the patches in the series and didn't have any other > comments. > > TBH I don't mind if you want to post another round or just push > something. We've got plenty of time to test and fix things up before > the next release. I'd be OK with the reviewed front of the series being merged, and then a v3 of the tail being posted (if that's not too much burden for Eric). I'm between patches #3 and #4, so if Eric agrees, I could resume my review with *v3* of patch#4. I can also continue reviewing this version if that's preferred. (The main reason I'm trying to review this series meticulously is to learn about libnbd for the long term; it's a learning investment on my part. It's not because I insist that the series not be merged without my approval! :))