On Wed, Aug 8, 2018 at 6:17 PM Richard W.M. Jones <rjones(a)redhat.com> wrote:
 On Wed, Aug 08, 2018 at 06:08:45PM +0300, Nir Soffer wrote:
 > Can we simplify this these 2 calls?
 >
 >     nbdkit_error ("%s: %s: error", script, callback);
 >     PyErr_PrintEx (0);
 No, we want to ensure errors go through the nbdkit_error function so
 that we can in future implement syslog logging.
 > In this case we don't to fallback to the simple error print.
 Do you mean in the case of using PyErr_PrintEx or more generally
 falling back is a problem?
 
Just for PyErr_PrintEx, since it cannot fail.
 Rich.
 --
 Richard Jones, Virtualization Group, Red Hat
 
http://people.redhat.com/~rjones
 Read my programming and virtualization blog: 
http://rwmj.wordpress.com
 virt-builder quickly builds VMs from scratch
 
http://libguestfs.org/virt-builder.1.html