Re: [Libguestfs] [PATCH v2 7/7] build: stop looking for ocaml-libvirt
On Tuesday, 27 November 2018 12:17:52 CET Richard W.M. Jones wrote:
On Tue, Nov 27, 2018 at 11:13:12AM +0000, Daniel P. Berrangé wrote:
> On Tue, Nov 27, 2018 at 11:59:08AM +0100, Pino Toscano wrote:
> > We ship our own copy of it, so we do not need the external version.
> > (Also, the latest upstream version of ocaml-libvirt was already not
> > usable to build the test harness of v2v.)
>
> This is a significant step backwards from a Fedora packaging POV
> which expects maintainers to unbundle any 3rd party deps and use
> the external packages instead.
Yes, I already know what mean bundling stuff vs what a distro expects.
> Why can't we just do a new release of ocaml-libvirt upstream
and
> put that into Fedora (and other distros that care) straightaway.
See the commit message of patch #2, and the libvirt.README file added
by that patch.
Also: we have already a similar situation for ocaml-augeas, from
mid-2017 even.
Also: I thought the agreed plan was to do an upstream release of
ocaml-libvirt, and then require it (as an external dependency)
starting with libguestfs 1.40?
https://www.redhat.com/archives/libguestfs/2018-September/msg00012.html
This mentions delaying it after 1.40, which is OK (I posted here mostly
to refresh it, especially after the upstream work on libvirt-ocaml),
but not making it an external dependency.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)