Re: [Libguestfs] [libnbd PATCH v3 14/22] info: Expose extended-headers support through nbdinfo

On Thu, May 25, 2023 at 08:01:00AM -0500, Eric Blake wrote: > Add another bit of overall server information, as well as a '--can > extended-headers' silent query. For now, the testsuite is written > assuming that when nbdkit finally adds extended headers support, it > will also add a --no-eh kill switch comparable to its existing --no-sr > switch. > > +=item nbdinfo --can extended-headers URI > + > +Test if server supports extended headers (a prerequisite for > +supporting 64-bit commands; implies structured replies as well). Maybe we should add "--has" and "--have" as yet more synonyms for --is/--can. "--has extended-headers" reads better. It's only tiny extra change to this array: https://gitlab.com/nbdkit/libnbd/-/blob/27d4ea0bd833f17349e7696353c7a9df0...

Reviewed-by: Richard W.M. Jones <rjones(a)redhat.com&gt;