Re: [Libguestfs] [v2v PATCH] windows_virtio: favor "fwcfg" over "qemufwcfg"
On 1/5/23 11:31, Richard W.M. Jones wrote:
This is a feature ("duck typing"
https://en.wikipedia.org/wiki/Duck_typing).
Ah, good point. I guess I've heard of it before, it's just always seemed
so heretical to me (coming from an "inheritance" background rather than
a "pattern matching" background) that I've never internalized it.
Since the patch is upstream, shouldn't the bug (2151752) be moved
to POST?
Or is there more to do?
Haha, no, you are right; that's a timing mistake on my part.
I merged the patch on 22 Dec 2022
(<https://bugzilla.redhat.com/show_bug.cgi?id=2151752#c21>), but back
then I didn't know about a rebase BZ (or even a *plan* for rebasing I
think?), so I couldn't set up a dependency, and therefore I refrained
from moving the BZ to post.
Later (on 31 Dec 2022), when I found out about the rebase BZ, I set up
the dependencies from the rebase BZ's perspective
<https://bugzilla.redhat.com/show_bug.cgi?id=2135762#c2>;, but then I
missed moving the original BZ to POST. :)
Sorry about that, doing it now.
Laszlo