Re: [Libguestfs] [PATCH V4 3/3] umount: use Dev_or_Path for the argument type
On 07/24/2012 07:23 PM, Richard W.M. Jones wrote:
On Tue, Jul 24, 2012 at 06:57:49PM +0800, Wanlong Gao wrote:
> On 07/24/2012 04:47 PM, Wanlong Gao wrote:
>> Use Dev_or_Path.
>> Remove the RESOLVE_DEVICE since Dev_or_Path will generate
>> the resolve code.
>>
>> Signed-off-by: Wanlong Gao <gaowanlong(a)cn.fujitsu.com>
>
> Forgot this one?
No, I was checking it in detail.
The patch changes the sematics of 'umount', because the generator adds
'REQUIRE_ROOT_OR_RESOLVE_DEVICE'. In other words, umount will now
require root.
I thought that this would break mkmountpoint and friends, but in fact
it turns out this is not the case.
When I've finished testing it I'll push it provided I don't find any
regressions.
Got it, you always think more than me.
Thanks,
Wanlong Gao
Rich.