[Libguestfs] [PATCH 1/4] v2v: drop useless forced gc
Forced gc meant, according to the comment, to prevent the leak of the
auxiliary guestfs handle (and thus an extra qemu instance) to the data
copy stage of the v2v conversion, doesn't actually achieve its goal:
it's easy to check that in reality that extra qemu instance survives
till the end of v2v execution.
So drop it; an alternative scheme will be proposed in the followup
patches.
Signed-off-by: Roman Kagan <rkagan(a)virtuozzo.com>
---
v2v/v2v.ml | 8 --------
1 file changed, 8 deletions(-)
diff --git a/v2v/v2v.ml b/v2v/v2v.ml
index 242f129..7c47ea0 100644
--- a/v2v/v2v.ml
+++ b/v2v/v2v.ml
@@ -320,14 +320,6 @@ let rec main () =
if verbose () then
printf "%s%!" (string_of_target_buses target_buses);
- (* Force a GC here, to ensure that we're using the minimum resources
- * as we go into the copy stage. The particular reason is that
- * Windows conversion may have opened a second libguestfs handle
- * pointing to the virtio-win ISO, which is only closed when the
- * handle is GC'd.
- *)
- Gc.compact ();
-
let delete_target_on_exit = ref true in
let targets =
--
2.4.3