Re: [Libguestfs] [PATCH v2 07/11] v2v: add support for SUSE VMDP drivers
On Wed, May 18, 2016 at 02:00:55PM +0200, Cédric Bosdonnat wrote:
let rec configure_firstboot () =
- configure_rhev_apt ();
+ match installer with
+ | None -> ()
+ | Some (`RhevApt, tool_path) -> configure_rhev_apt tool_path
+ | Some (`VmdpExe, tool_path) -> configure_vmdp tool_path
+ | Some (_, installer_path) -> info (f_"No setup function for installer
'%s'") installer_path;
This final case (Some (_, ...)) shouldn't be needed. Does
the compiler complain if you remove this line?
The rest of this patch looks OK.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/