Re: [Libguestfs] [PATCH 2/2] daemon: Remove redundant fork in commandrvf

On Thu, Dec 13, 2012 at 03:22:39PM +0000, Matthew Booth wrote: > Currently the code is doing a redundant fork when passed the > COMMAND_FLAG_CHROOT_COPY_FILE_TO_STDIN flag. The additional sub-process does a > chroot() which has no effect because all file handles are already open at that > point, then simply copies its input to its output. > > This change simply replaces the above with a dup2 of the passed file handle to > STDIN of the command process. NACK. This removes the chroot call, so I don't see how it can be right.