Re: [Libguestfs] [PATCH nbdkit 3/3] python: Remove extraneous static keyword
On Mon, Mar 23, 2020 at 12:28:12PM +0000, Richard W.M. Jones wrote:
From: Yifan Gu <gyf304(a)gmail.com>
The create_nbdkit_module function is intended to be exported, therefore
the static keyword is not needed and prevents building on MSYS2.
---
plugins/python/python.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/plugins/python/python.c b/plugins/python/python.c
index a1a0438b..adc1aaa5 100644
--- a/plugins/python/python.c
+++ b/plugins/python/python.c
@@ -224,7 +224,7 @@ static struct PyModuleDef moduledef = {
NULL
};
-static PyMODINIT_FUNC
+PyMODINIT_FUNC
create_nbdkit_module (void)
{
PyObject *m;
--
I don't believe this is correct. We call
PyImport_AppendInittab ("nbdkit", create_nbdkit_module);
later on so the function shouldn't need to public. What's the actual
error when compiling this?
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW