Re: [Libguestfs] [PATCH nbdkit 7/8] vddk: Implement extents.

On Sat, Mar 23, 2019 at 02:29:54PM -0500, Eric Blake wrote: > On 3/20/19 5:11 PM, Richard W.M. Jones wrote: ... > > + for (i = 0; i < block_list->numBlocks; ++i) { > > + uint64_t offset, length; > > + > > + offset = block_list->blocks[i].offset * VIXDISKLIB_SECTOR_SIZE; > > + length = block_list->blocks[i].length * VIXDISKLIB_SECTOR_SIZE; > > + > > + /* The query returns blocks. We must insert holes between the > > + * blocks as necessary. > > + */ > > + if (position < offset) { > > + if (nbdkit_add_extent (extents, > > + offset, length, > > + NBDKIT_EXTENT_HOLE | NBDKIT_EXTENT_ZERO) == -1) > > + goto error_in_add; > > + } > > + > > + if (nbdkit_add_extent (extents, > > + offset, length, 0 /* allocated data */) == -1) { > > + error_in_add: > > + DEBUG_CALL ("VixDiskLib_FreeBlockList", "block_list"); > > + VixDiskLib_FreeBlockList (block_list); > > + return -1; > > + } > > + > > + position = offset + length; > > This inner loop might be long; you could add this: > > if (req_one) > break;