Libguestfs desired version installation
by Teja Konapalli
Hi Richard ,
Happy weekend.
I had one question regarding desired version installation of libguestfs, suppose if had RHEL 8.0 default libguestfs is 1.38.0 and I want to install 1.50.0 in same machine is it possible to install?
Thanks
Teja K
1 year, 6 months
[libnbd PATCH v2 0/6] Fix fuzzer fallout
by Eric Blake
Cat's out of the bag: Rich's fuzzer run found not one, but two
independent assertion failures that a malicious server could trigger
in my recent 64-bit extension code additions. What's more, in the
process of fixing them, we've discovered another long-standing issue
where nbd_get_size() returns confusing results compared to its
documentation, when talking to an odd server that reports a really
large export size.
After off-list discussion between Rich, Laszlo, and myself, we didn't
think an embargoed CVE against libnbd is necessary (the assertion
failures only happen to unstable releases, and the nbd_get_size()
misbehavior does not happen with normal servers and has been in place
since v1.0, so it is nothing new), so I am posting the series now for
public review. But we will still be reaching out to secalert for
their opinion (it may be that they still see a low-priority exploit in
an app that gets confused when trying to use a negative size as a loop
bound, for example). Once they answer, and regardless of whether we
end up doing a libnbd CVE after all, I will follow up to the mailing
list with a security incident (client apps that demand a positive
export size should probably favor nbd_get_size()<0 over
nbd_get_size()==-1).
Eric Blake (6):
states: Tweak comment in OPT_GO state handler
fuzzing: Disable client-side strictness checks
api: Sanitize sizes larger than INT64_MAX
block_status: Fix assertion with large server size
block_status: Fix assertion on bad 64-bit block status reply
info: Tolerate missing size
generator/API.ml | 6 +++-
generator/states-newstyle-opt-go.c | 5 ++-
generator/states-reply-chunk.c | 50 ++++++++++++++++--------------
generator/C.ml | 2 +-
lib/flags.c | 6 ++++
fuzzing/libnbd-fuzz-wrapper.c | 5 ++-
info/show.c | 25 ++++++++-------
7 files changed, 60 insertions(+), 39 deletions(-)
--
2.41.0
1 year, 6 months
regression: file does not understand the -S option
by Olaf Hering
Recently a commit was added to call 'file -zSb' instead of 'file -zb'.
This causes a regression on Leap 15 (but not on Tumbleweed), because
file 5.32 does not understand the -S option.
How can this be fixed properly, to handle both cases either at runtime
or at buildtime?
Thanks,
Olaf
1 year, 6 months
[PATCH libguestfs] daemon: Omit 'file -S' option on older distros that lack support
by Richard W.M. Jones
OpenSUSE LEAP 15 lacks support for this option, so test for it before
using it.
See-also: https://listman.redhat.com/archives/libguestfs/2023-September/032613.html
Report-by: Olaf Hering
Fixes: commit 23986d3c4f4d1f9cbac44cc743d3e6af721e4237
---
daemon/Makefile.am | 2 ++
daemon/file.ml | 10 ++++++++--
daemon/file_helper.ml | 29 +++++++++++++++++++++++++++++
daemon/file_helper.mli | 19 +++++++++++++++++++
daemon/filearch.ml | 5 ++++-
5 files changed, 62 insertions(+), 3 deletions(-)
diff --git a/daemon/Makefile.am b/daemon/Makefile.am
index bb2e58d014..01c0f6416c 100644
--- a/daemon/Makefile.am
+++ b/daemon/Makefile.am
@@ -280,6 +280,7 @@ SOURCES_MLI = \
devsparts.mli \
file.mli \
filearch.mli \
+ file_helper.mli \
findfs.mli \
inspect.mli \
inspect_fs.mli \
@@ -321,6 +322,7 @@ SOURCES_ML = \
btrfs.ml \
cryptsetup.ml \
devsparts.ml \
+ file_helper.ml \
file.ml \
filearch.ml \
isoinfo.ml \
diff --git a/daemon/file.ml b/daemon/file.ml
index 1f87b190c1..f0ef181938 100644
--- a/daemon/file.ml
+++ b/daemon/file.ml
@@ -43,7 +43,10 @@ let file path =
| S_SOCK -> "socket"
| S_REG ->
(* Regular file, so now run [file] on it. *)
- let out = command "file" ["-zSb"; Sysroot.sysroot_path path] in
+ let file_options =
+ sprintf "-z%sb"
+ (if File_helper.file_has_S_option () then "S" else "") in
+ let out = command "file" [file_options; Sysroot.sysroot_path path] in
(* We need to remove the trailing \n from output of file(1).
*
@@ -54,6 +57,9 @@ let file path =
String.trimr out
)
else (* it's a device *) (
- let out = command "file" ["-zSbsL"; path] in
+ let file_options =
+ sprintf "-z%sbsL"
+ (if File_helper.file_has_S_option () then "S" else "") in
+ let out = command "file" [file_options; path] in
String.trimr out
)
diff --git a/daemon/file_helper.ml b/daemon/file_helper.ml
new file mode 100644
index 0000000000..f8c4bcbe56
--- /dev/null
+++ b/daemon/file_helper.ml
@@ -0,0 +1,29 @@
+(* guestfs-inspection
+ * Copyright (C) 2009-2023 Red Hat Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ *)
+
+open Std_utils
+
+(* Does [file] support the [-S] / [--no-sandbox] option
+ * (not on OpenSUSE LEAP 15).
+ *)
+let file_has_S_option = lazy (
+ let out = Utils.command "file" ["file"; "--help"] in
+ String.find out "--no-sandbox" >= 0
+
+)
+let file_has_S_option () = Lazy.force file_has_S_option
diff --git a/daemon/file_helper.mli b/daemon/file_helper.mli
new file mode 100644
index 0000000000..a644cf6de2
--- /dev/null
+++ b/daemon/file_helper.mli
@@ -0,0 +1,19 @@
+(* guestfs-inspection
+ * Copyright (C) 2009-2023 Red Hat Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ *)
+
+val file_has_S_option : unit -> bool
diff --git a/daemon/filearch.ml b/daemon/filearch.ml
index 7c858129db..cf784f18a2 100644
--- a/daemon/filearch.ml
+++ b/daemon/filearch.ml
@@ -128,7 +128,10 @@ and cpio_arch magic orig_path path =
| bin :: bins ->
let bin_path = tmpdir // bin in
if is_regular_file bin_path then (
- let out = command "file" ["-zSb"; bin_path] in
+ let file_options =
+ sprintf "-z%sb"
+ (if File_helper.file_has_S_option () then "S" else "") in
+ let out = command "file" [file_options; bin_path] in
file_architecture_of_magic out orig_path bin_path
)
else
--
2.41.0
1 year, 6 months
LIBGUESTFS mount disk failure
by Teja Konapalli
Hi Richard & Team,
Could you please help here on the below failure of mounting disk using libguestfs.
OS version: RHEL 8.2
Libguestfs version: 1.38.0 stable
Error logs:
libguestfs: trace: add_drive_ro "/var/opt/tmp/GRE//RAJA/RAJAT-flat.vmdk"
libguestfs: trace: add_drive "/var/opt/tmp/GRE//RAJA/RAJAT-flat.vmdk" "readonly:true"
libguestfs: creating COW overlay to protect original drive content
libguestfs: trace: disk_create "/tmp/libguestfsCpl8My/overlay3.qcow2" "qcow2" -1 "backingfile:/var/opt/tmp/GRE//RAJA/RAJAT-flat.vmdk"
libguestfs: command: run: qemu-img
libguestfs: command: run: \ create
libguestfs: command: run: \ -f qcow2
libguestfs: command: run: \ -o backing_file=/var/opt/tmp/GRE//RAJA/RAJAT-flat.vmdk
libguestfs: command: run: \ /tmp/libguestfsCpl8My/overlay3.qcow2
Formatting '/tmp/libguestfsCpl8My/overlay3.qcow2', fmt=qcow2 size=21474836480 backing_file=/var/opt/tmp/GRE//RAJA/RAJAT-flat.vmdk cluster_size=65536 lazy_refcounts=off refcount_bits=16
libguestfs: trace: disk_create = -1 (error)
libguestfs: trace: add_drive = -1 (error)
libguestfs: trace: add_drive_ro = -1 (error)
libguestfs: trace: close
libguestfs: closing guestfs handle 0x1e89340 (state 0)
libguestfs: command: run: rm
libguestfs: command: run: \ -rf /tmp/libguestfsCpl8My
1 year, 6 months
[libnbd PATCH] generator: Fix assertion with ill-formed 64-bit block status reply
by Eric Blake
If a server replies to a block status command with an invalid length
in NBD_REPLY_TYPE_BLOCK_STATUS_EXT, we correctly detect the server's
error, but fail to mark that we've consumed enough data off the wire
to resync back to the server's next reply. Symptoms seen during a
fuzzing run:
│ $ ./fuzzing/libnbd-fuzz-wrapper
│+id\:000001\,sig\:06\,src\:000396\,time\:16888628\,execs\:54159419\,op\:havoc\,rep\:4
│ libnbd-fuzz-wrapper: generator/states-reply-chunk.c:698: enter_STATE_REPLY_CHUNK_REPLY_FINISH:
│+Assertion `h->payload_left == 0' failed.
│ Aborted (core dumped)
│ read: Connection reset by peer
Appears to be a casualty of rebasing: I added h->payload_left
verification fairly late in the game, then floated it earlier in the
series, and missed a spot where I added a state machine jump to RESYNC
without having updated h->payload_left. An audit of all other
assignments to h->rlen in that file was able to find corresponding
assignments to h->payload_left (often the next statement, but
sometimes split across states based on what made the next state easier
to code).
Requires a non-compliant server, but I was able to come up with a
one-line tweak to pending qemu patches that could trigger it. Not
creating a CVE as it only appears in unstable releases.
Fixes: ab992766cd ("block_status: Accept 64-bit extents during block status")
Thanks: Richard W.M. Jones <rjones(a)redhat.com>
Signed-off-by: Eric Blake <eblake(a)redhat.com>
---
I'm investigating another crash that Rich sent me off-list, but I
suspect it will be a similar non-CVE situation caused by my recent
64-bit extension patches.
I'll wait to apply this one for just a bit more, in case I can get the
corpus file or two from Rich's fuzzing run to add to
fuzzing/testcase_dir.
generator/states-reply-chunk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/generator/states-reply-chunk.c b/generator/states-reply-chunk.c
index 2cebe456..a5d3aefe 100644
--- a/generator/states-reply-chunk.c
+++ b/generator/states-reply-chunk.c
@@ -476,6 +476,7 @@ REPLY.CHUNK_REPLY.RECV_BS_HEADER:
if (h->bs_count != be32toh (h->sbuf.reply.payload.bs_hdr_64.count)) {
h->rbuf = NULL;
h->rlen = h->payload_left;
+ h->payload_left = 0;
SET_NEXT_STATE (%RESYNC);
return 0;
}
--
2.41.0
1 year, 6 months
LIBGUESTFS supported version
by Teja Konapalli
Hi Team,
Am trying to install libguestfs in my redhat 8.2 version default its installing 1.38.4. Could you please help us with the installation of version 1.50 libguestfs and supported RHEL versions.
Regards,
Teja K
1 year, 6 months
Plans for nbdkit 1.36 & libnbd 1.18
by Richard W.M. Jones
The current stable versions of nbdkit & libnbd were first released on:
nbdkit 1.34.0 => 14 April 2023
libnbd 1.16.0 => 18 April 2023
which is about 5 months ago. Since we tend to release these projects
approximately every 6 months, I'd like to aim for a release at the end
of September or beginning of October, about 3 weeks from now.
If there are large features, then let's discuss whether to add them
now or else hold off. (IIUC all 64 bit NBD patches are now upstream?
Are there more?)
I'll prepare draft release notes in the coming weeks.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
nbdkit - Flexible, fast NBD server with plugins
https://gitlab.com/nbdkit/nbdkit
1 year, 6 months
