7:44 a.m.
This is a NFC on its own, but provides a place-holder for drive metadata which
can be used after launch.
---
src/guestfs-internal.h | 17 +++++++-
src/guestfs.c | 20 +++++++++
src/launch.c | 104 +++++++++++++++++++++++++++---------------------
src/virt.c | 4 +-
4 files changed, 96 insertions(+), 49 deletions(-)
7:44 a.m.
New subject: [PATCH 2/5] NFC: Remove unnecessary goto
---
src/inspect_fs_unix.c | 12 +++++-------
1 files changed, 5 insertions(+), 7 deletions(-)
7:44 a.m.
New subject: [PATCH 3/5] inspect: Add drive naming hints
We currently use a heuristic to guess how drive names we find referenced in the
guest map to drive names in the appliance. If this heuristic fails it can cause
inspection to fail.
This change adds a new 'name' option to add_drive_opts, which allows the user to
explicitly pass the name of a drive to libguestfs if it is known. This change
also updates the fstab-parsing inspection code to use this information if it is
available.
---
generator/generator_actions.ml | 7 ++++-
regressions/test-inspect-fstab.sh | 40 ++++++++++++++++++++++++---
src/guestfs-internal.h | 1 +
src/inspect_fs_unix.c | 55 ++++++++++++++++++++++++-------------
src/launch.c | 4 +++
5 files changed, 83 insertions(+), 24 deletions(-)
7:44 a.m.
New subject: [PATCH 4/5] inspect: Don't assume number of captures in match functions
It is possible for the pcre library to return a variable number of captures for
a single regular expression. e.g.:
^/dev/(cciss/c\d+d\d+)(?:p(\d+))?$
This will return either 1 or 2 captures depending on whether the device has a
partition suffix. The current match wrappers don't allow for this, and require
that a predictable number of matches are returned.
This change updates match, match1, match2, and match3 to ignore the specific
number of matches returned. Instead, any returned captures are assigned to the
given arguments, and any remaining arguments are set to NULL.
---
src/match.c | 43 +++++++++++++------------------------------
1 files changed, 13 insertions(+), 30 deletions(-)
7:44 a.m.
New subject: [PATCH 5/5] inspect: Handle cciss devices in /etc/fstab
---
regressions/test-inspect-fstab.sh | 36 ++++++++++++++++++++++++++++++++++++
src/inspect_fs_unix.c | 32 ++++++++++++++++++++++++++++++++
2 files changed, 68 insertions(+), 0 deletions(-)
4708
days inactive
4708
days old
4 comments
1 participants
participants (1)
-
Matthew Booth