On Tue, Aug 28, 2012 at 11:59:11AM +0200, Jim Meyering wrote: > Hi Rich, > > I ran these commands as non-root: > > ./autogen.sh && make && make distcheck > > It got most of the way through, but failed in the VPATH part > while rebuilding from a ./_build subdir, like this: > > make[4]: Entering directory `/h/j/w/co/hivex/hivex-1.3.6/_build/ocaml' > mkdir -p /usr/lib64/ocaml > mkdir -p /usr/lib64/ocaml/stublibs > ocamlfind install \ > -ldconf ignore -destdir /usr/lib64/ocaml \ > hivex \ > META *.so *.a *.cma *.cmi ../../ocaml/*.mli *.cmx *.cmxa > ocamlfind: Cannot mkdir /usr/lib64/ocaml/hivex: Permission denied > make[4]: *** [install-data-hook] Error 2 > make[4]: Leaving directory `/h/j/w/co/hivex/hivex-1.3.6/_build/ocaml' > make[3]: *** [install-data-am] Error 2 > make[3]: Leaving directory `/h/j/w/co/hivex/hivex-1.3.6/_build/ocaml' > make[2]: *** [install-am] Error 2 > make[2]: Leaving directory `/h/j/w/co/hivex/hivex-1.3.6/_build/ocaml' > make[1]: *** [install-recursive] Error 1 > make[1]: Leaving directory `/h/j/w/co/hivex/hivex-1.3.6/_build' > make: *** [distcheck] Error 1 > > Obviously, it should not be trying to create directories under /usr. The rule in the Makefile.am is: install-data-hook: mkdir -p $(DESTDIR)$(OCAMLLIB) mkdir -p $(DESTDIR)$(OCAMLLIB)/stublibs $(OCAMLFIND) install \ -ldconf ignore -destdir $(DESTDIR)$(OCAMLLIB) \ $(PACKAGE_NAME) \ $(install_files) So that must mean that DESTDIR is not being set. There are also environment variables that ocamlfind itself will use (see findlib.conf(5)). Although they don't appear to be relevant here it may be worth looking at that man page.

On Tue, Aug 28, 2012 at 05:46:49PM +0200, Jim Meyering wrote: > In Makefile.am files, installation-related rules > must honor the $(prefix) Makefile variable. For example, > in many Makefiles you'll find files being installed to > $(DESTDIR)$(bindir), with these definitions: > > bindir = ${exec_prefix}/bin > exec_prefix = ${prefix} > > Currently, $(OCAMLLIB) (set from m4/ocaml.m4 by running $OCAMLC) is set > to /usr/lib64/ocaml for me. If we could make it include $(exec_prefix), > that would solve this problem. I see. Not an easy one to solve however. The OCaml library path comes from running: $OCAMLC -where

This is not an (especially) peculiar OCaml thing. For example we detect the Python library path using: $PYTHON -c "import distutils.sysconfig; \ print (distutils.sysconfig.get_python_inc ());" This allows multiple parallel Python installations to get along on Debian. The user just specifies the $PYTHON binary and everything works off that. So I'm fairly sure the same bug exists in some Python, Perl and Ruby code in libguestfs too. Rich.

On Tue, Aug 28, 2012 at 06:33:34PM +0200, Jim Meyering wrote: > Currently, if root runs "make distcheck", I suspect it would put things in > $OCAMLLIB. That would be rather antisocial, but maybe you have something > to abort a "make distcheck" when it's run by root? I haven't tried that. The truth of the matter is that we don't use make distcheck. The [not open-sourced yet] whenjobs-based release scripts build a candidate tarball from git (ie. make dist). Said tarball is then sent to several build servers which './configure && make && make check' it. So no distcheck is required, and what we are doing now is arguably more thorough.

I'm curious, do your buildservers use gitbuilder, or something else to determine the commits to build? I like the look of whenjobs; what's the appropriate mailing list for that utility?