Re: [Libguestfs] [PATCH] file: Better support for read-only files

On Tue, Mar 02, 2021 at 08:44:04AM -0600, Eric Blake wrote: Actually it doesn't because there's a misspelling. I modified the patch s/wintfile/winfile/, but the newly added test still fails on Wine with: nbdkit: file[1]: debug: file: flush nbdkit: file[1]: error: Z:\home\rjones\d\nbdkit-windows\tests\file-readonly.img: FlushFileBuffers: 5 nbdkit: file[1]: debug: sending error reply: Input/output error ... libnbd: debug: nbdsh: nbd_flush: leave: error="nbd_flush: flush: command failed: Input/output error" ... Traceback (most recent call last): File "/usr/lib64/python3.9/site-packages/nbdsh.py", line 119, in shell exec(c, d, d) File "<string>", line 9, in <module> File "/usr/lib64/python3.9/site-packages/nbd.py", line 1608, in flush return libnbdmod.flush(self._o, flags) nbd.Error: nbd_flush: flush: command failed: Input/output error (EIO) My guess is that Win32 doesn't let you flush a read-only file! The actual error is ERROR_ACCESS_DENIED (== 5). The attached patch fixes both issues. Rest of the patch is fine, so ACK. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/