Re: [Libguestfs] [p2v PATCH 2/6] restrict vCPU topology to (a) fully populated physical, or (b) 1 * N * 1

On Mon, Sep 05, 2022 at 01:25:27PM +0200, Laszlo Ersek wrote: I just realised I'm not completely sure what "densely populated" means here. I think we should have a bit more explanation. How about something like: "p2v.vcpu.dense_topo" => manual_entry->new( shortopt => "", # ignored for booleans description => " Copy the physical machine's complete CPU topology (sockets, cores and threads) to the guest. Disabled by default. If disabled, the C<p2v.vcpu.cores> setting takes effect.", (Which might also imply that we rename this something like "complete_topo" or "full_topo" but I'll leave that to you.) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top