Re: [Libguestfs] [libnbd RFC PATCH] First stab at CI infrastructure

On Thu, Apr 08, 2021 at 05:39:17PM +0200, Martin Kletzander wrote: I don't usually enable warnings with clang, but I've pushed this which fixes the problem above (and a further one) for me: https://gitlab.com/nbdkit/libnbd/-/commit/28816a5f8829f474d07351611140f46... This is actually because: checking for nbdkit... no but we go ahead and run the golang tests anyway. Fixed here: https://gitlab.com/nbdkit/libnbd/-/commit/b15dde588f47894f9656ea62eb63215... but there may be more problems after this, we'll see. This has golang 1.10 which predates the inclusion of modules. There's basically no sane way to make libnbd work with both old and new golang, so I would suggest --disable-golang on this platform. (In fact is it possible to disable features on different CI platforms?) I think "make distcheck" is a nice-to-have but ISTR that making it work was a lot of work for libguestfs. Sure, go for it. Thanks again, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html