Re: [Libguestfs] [PATCH] New API: is-lv: check if a block device is a logical volume (RHBZ#619793)

On Fri, Jul 30, 2010 at 04:48:27PM +0100, Matthew Booth wrote: >> + ("is_lv", (RBool "lvflag", [Device "device"]), 264, [Optional "lvm2"], >> + [InitBasicFSonLVM, IfAvailable "lvm2", TestOutputTrue ( >> + [["is_lv"; "/dev/VG/LV"]]); > > This obviously needs to be a real test... > >> + InitBasicFSonLVM, IfAvailable "lvm2", TestOutputFalse ( >> + [["is_lv"; "/dev/sda1"]])], >> + "test if device is a logical volume", >> + "\ >> +This command tests whether C<device> is a logical volume, and >> +returns true iff this is the case."); >> + >> ] > > ACK once the test is added. Not sure I understand. Those are both real tests (and I checked -- they do both pass).