Re: [Libguestfs] [PATCH supermin 2/3] init: Move variable declarations to the top of the function.
On Wednesday, 19 April 2017 11:57:27 CEST Richard W.M. Jones wrote:
No functional change, just change the style to the one used
by libguestfs.
---
Mostly LGTM.
while (fgets (line, sizeof line, fp)) {
- size_t n = strlen (line);
+ n = strlen (line);
This one I would leave -- as it avoids using a wrong/nonsense value
outside of the loop, and at the same time making sure it is properly
reset every time.
Thanks,
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)