Re: [Libguestfs] Libguestfs (1.22.6) driver/changes for mingw/win32

On Thu, Feb 13, 2014 at 04:54:09PM +0200, Or Goshen wrote: A couple of points first: - You need to start using git. - You need to develop against the git head, not the old 1.22 branch. I took the tarball and turned it into a git commit, which I then cherry picked on top of head. (Except for 'bootstrap' which seems to be a completely rewritten file -- so I created it as 'bootstrap.win32'). This is attached so you can take it from here. As this was mostly an automatic process -- git did the hard work, I just resolved a few things that git could not resolve -- you need to check carefully that this patch still works. About the patch itself: The patch looks fairly sensible. There's some tidying up that could be done, and it would be nice to confine more of the changes so they don't affect the main code. But there's nothing here that can't be pushed upstream in some form, after a proper review and more testing. The qemu change needs to separately be submitted to the qemu mailing list, along with an explanation for why that is necessary. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#)