Re: [Libguestfs] [PATCH] daemon/rpm-c.c: Disable signature checking in librpm

On 03/15/22 11:31, Richard W.M. Jones wrote: > + rpmVSFlags oflags; > + > CAMLparam1 (unitv); > ts = rpmtsCreate (); > + > + /* Disable signature checking (RHBZ#2064182). */ > + oflags = rpmtsVSFlags (ts); > + rpmtsSetVSFlags (ts, oflags | RPMVSF_MASK_NOSIGNATURES); > + > iter = rpmtsInitIterator (ts, RPMDBI_PACKAGES, NULL, 0); > CAMLreturn (Val_unit); > } > The logic seems OK, but the execution seems to conflict with the *letter* of "Interfacing C with OCaml": https://ocaml.org/manual/intfc.html#ss:c-simple-gc-harmony """ Rule ‍1  A function that has parameters or local variables of type value must begin with a call to one of the CAMLparam macros [...] """ All ocaml-interfacing C functions I've seen thus far in the v2v projects, and one function that I just checked (namely guestfs_int_daemon_rpm_next_application()), conform to this. The documentation in "/usr/lib64/ocaml/caml/memory.h" seems to support this requirement: """ /* The following macros are used to declare C local variables and function parameters of type [value]. The function body must start with one of the [CAMLparam] macros. """ So, even if it may not matter in practice, I suggest introducing "oflags" *after* CAMLparam1().

With that update: Acked-by: Laszlo Ersek <lersek(a)redhat.com&gt;