Re: [Libguestfs] [PATCH nbdkit] freebsd: In nbdkit_nanosleep, fallback to calling nanosleep(2).
On 8/28/19 11:14 AM, Richard W.M. Jones wrote:
Rather than failing to compile on platforms which lack POLLRDHUP
such
as FreeBSD, simply fallback to the old method of sleeping.
This leaves the porting suggestions as a comment in case someone wants
to implement a better solution for particular platforms.
---
server/public.c | 38 ++++++++++++++++++++++++--------------
1 file changed, 24 insertions(+), 14 deletions(-)
This means 'make check' will fail on FreeBSD; do we have a way to
introspect whether a platform lacks POLLRDHUP this is the case, to skip
rather than fail tests/test-shutdown.sh on those platforms?
At any rate, the fallback is reasonable, even if underwhelming in
performance, so ACK.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 488 bytes)