On 1/17/24 07:17, Laszlo Ersek wrote:
(4) Can we introduce a helper function that takes a URI and returns
a
tuple (server, port, user, path)? Then it could be called from both
"input_vmx.ml" and "parse_domain_from_vmx.ml", plus in the latter,
we
could use the path component of the returned tuple for both the
"Ssh.download_file" call and for the "name_from_disk" call.
... In effect I'm suggesting to *replace* the *_of_uri helpers in the
Ssh module with a new (unified) helper function in -- say -- Utils. If
you agree with that idea, then it might be best to first perform that
conversion / extraction in a separate patch, prepended to this one.
If you don't feel like doing this, that's not a problem either:
Reviewed-by: Laszlo Ersek <lersek(a)redhat.com>