[Libguestfs] Re: [External] Re: [PATCH] VxFS Filesystem support to libguestfs
On Mon, Jul 01, 2024 at 11:24:59AM +0000, Ravi Singh wrote:
A few basics first:
- The commit doesn't have an author name. : Fixed
- The commit has no information at all about the change. : Fixed
This commit message is just a list of what changed, which is not how
to write good commit messages. (Also the summary line is bad too).
There are numerous examples of good commit messages in the Linux
kernel repository:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/?s...
and a long discussion here:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
- One file at least has whitespace problems, adding empty lines at
the end of the file. : Fixed
- There are no tests at all. : In progress.
- Copyright dates are not 2024. : Fixed.
- Make the first line of the top comment be about the file, not just
something that was copied and pasted.: Please point out which file.
Most of them ...
And let's think about how to split up the commits to make a
story:
This isn't fixed either. Think about telling a story.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
nbdkit - Flexible, fast NBD server with plugins
https://gitlab.com/nbdkit/nbdkit