Re: [Libguestfs] [PATCH nbdkit v3 3/3] Add partitioning plugin.

On 9/17/18 4:27 PM, Richard W.M. Jones wrote: >Create a partitioned virtual drive from a list of one or more files >each containing single partitions. The plugin concatenates the files >together and generates a virtual partition table so that NBD clients >see a single partitioned disk. > >For example: > > nbdkit partitioning boot.img swap.img root.img > >creates a virtual disk with 3 partitions. >--- >+++ b/plugins/partitioning/nbdkit-partitioning-plugin.pod >+If the underlying file is a multiple of 512 bytes then this is a >+no-op: >+ >+ nbdkit --filter=partition partitioning file --partition=1 Filter options are not specified with --. I've pushed the obvious fix. Maybe they should, though. Is it worth teaching nbdkit that any unrecognized option that resembles --key=value should first undergo an attempted translation into 'key=value' passed on to the filter/plugin .config, before declaring it as an unknown option?