Re: [Libguestfs] RFC: copy-attributes command
On Fri, Jan 10, 2014 at 01:33:38PM +0000, Richard W.M. Jones wrote:
The API is now pretty confusing. Each OBool flag is really a
tristate. It can either be "true", "false" or "not
specified".
Therefore I think it should be:
xattributes:true # copies only xattrs and nothing else
all:true # copies everything
all:true xattributes:false # copies everything except xattrs
In other words, 'all' changes the default (ie. "not specified") state
of the other flags.
To be clearer, the four OBool parameters would be:
[OBool "all"; OBool "mode"; OBool "ownership"; OBool
"xattributes"]
So looking at your v2 patch a bit more, I think this is what you
already did, except that "skipmode" is backwards from the other flags.
I think we're in agreement, except I think "skipmode" should just
become "mode" and not have negated meaning compared to the other
flags.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org