Re: [Libguestfs] [PATCH libnbd 2/3] lib: Implement closure lifetimes.

>> + if valid_flag then ( >> + if !comma then pr ", "; >> + comma := true; >> + if types then pr "int "; >> + pr "valid_flag"; > > Should this be 'unsigned int valid_flag', as bitmasks over signed values > have awkward semantics if you touch the sign bit? But I'm okay with int > for now, as it matches 'int nbd_aio_get_direction(...)' and > nbd_pread_structured using 'int status' in its callback. Yes I can change it to unsigned - using a signed type was a mistake. I think we can change nbd_pread_structured (and friends) to use either unsigned or uint32_t which is consistent with other flag parameters. However we can't easily change nbd_aio_get_direction as that needs to be a signed type to indicate errors, at least without awkward casting. I'll come up with a separate patch.