Re: [Libguestfs] [V2V PATCH v3 5/6] v2v, in-place: introduce --block-driver command line option
On Tue, Mar 14, 2023 at 04:06:18PM +0200, Andrey Drobyshev wrote:
Speaking of "make check": could you point out, for future
reference,
which particular sub-target you're referring to here? I can see these:
check-am, check-recursive, check-slow, check-TESTS, check-valgrind. And
none of them seems to refer to checking docs integrity. Yet running
entire "make check" might be quite time consuming.
(FYI I'm on holiday at the moment, back 1st April)
'make check' runs the test suite and as Laszlo said is reasonably fast
(on my machine anyway!). Well, it should be around 5-15 mins. You
can add -j4 or -j`nproc` or similar to parallelise the tests.
'make check-valgrind' runs the same tests but with valgrind. This is
highly unlikely to affect this patch series which only touches OCaml
code.
'make check-slow' runs an extra set of tests that as you might guess
are quite slow. I wouldn't bother with this for a simple patch. I
usually run it before major releases.
The other targets you mention are internally generated by automake.
Then you can run single tests, eg:
$ make check -C docs TESTS=" test-v2v-docs.sh "
Note that some individual tests depend on the test-data dir having
been built first to build a bunch of phony guests:
$ make -C test-data check
(If you do 'make check' it will do the test-data dir first.)
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v