Re: [Libguestfs] [PATCH 03/13] syntax-check: fix makefile_at_at_check
On Tue, Sep 23, 2014 at 05:20:29PM +0800, Hu Tao wrote:
check-valgrind:
- $(MAKE) VG="$(top_builddir)/run @VG@" check
+ $(MAKE) VG="$(top_builddir)/run $(VG)" check
make syntax-check is definitely wrong about these. We must not use
$(VG) here since it will cause VG to be expanded at the wrong place.
# Old RHEL 5 autoconf defines these, but RHEL 5 automake
doesn't
# create variables for them. So define them here if they're not
# defined already.
-builddir ?= @builddir@
-abs_builddir ?= @abs_builddir@
-srcdir ?= @srcdir@
-abs_srcdir ?= @abs_srcdir@
+builddir ?= $(builddir)
+abs_builddir ?= $(abs_builddir)
+srcdir ?= $(srcdir)
+abs_srcdir ?= $(abs_srcdir)
This is also wrong because RHEL 5 (which is what these rules target)
didn't support the $(..) syntax.
Sorry, but make syntax-check is largely broken, or at least advisory.
Maybe it's better to remove it if it doesn't do anything useful?
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top