Re: [Libguestfs] [PATCH] GuestOS: Fix _is_installed to return 0 if the package isn't installed

On 12/02/10 14:42, Richard W.M. Jones wrote: > On Fri, Feb 12, 2010 at 02:22:43PM +0000, Matthew Booth wrote: >> + my $error = $g->sh(join(' ', @$rpmcmd).' 2>&1 ||:'); > > Do we need more quoting here? > >> + return 0 if ($error =~ /not installed/); > > I guess this works because LANG=C in the appliance. > > If we ever enabled locales in the appliance it might break though. It > could therefore be a good idea to add LANG=C to the beginning of the > shell command above. > > Rich. > Added more quoting and LANG=C.