Re: [Libguestfs] [libnbd PATCH 00/20] Many CI fixes
I'm lukewarm about patch 3, but all the rest are fine so ACK on those.
More comments below:
On Tue, Jun 08, 2021 at 09:53:41AM +0200, Martin Kletzander wrote:
Lot of clean-ups for the CI. I also added support for easily
configurable way of skipping particular tests on selected distros.
However, I only skipped those that do not have and easy way of
detecting a broken dependency and such like. What is still missing
is:
- All the CentOS builds have issues with three tests that seem like
a protocol violation, but can very well be a bug in some test
dependency. Since this is the closest to RHEL we can get, I think
it's worth investigating.
I can't access the gitlab pipelines at the moment because there's some
problem with gitlab+Firefox, but which version of CentOS was this and
what kind of problem was it?
FWIW I built and testing libnbd and nbdkit on RHEL 7, RHEL 8 and
CentOS 9 Stream yesterday. I fixed a few minor things (see commit
history) but basically they were all working.
- FreeBSDs do not even build and it looks like some libtool wrapper
script is fed into a C preprocessor, which fails terribly due to
the script comments (but should not be fed there at all, of
course.
It was building OK for me yesterday (and also on OpenBSD). Do you
know what the error was?
- MacOS has issues, although that one is marked to allow failures
and the issue does not seem to be on our side anyway. I won't
look into it for a while and see if it sorts itself out.
I don't have a way to test/reproduce macOS failures but if I could see
the failures I might have some ideas.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v