Re: [Libguestfs] [PATCH v2 4/5] v2v:tests: use fake virtio-win drivers
On Thu, Oct 08, 2015 at 03:53:24PM +0100, Richard W.M. Jones wrote:
I'm just testing patches 1-3, and if they pass I will push them.
On Thu, Oct 08, 2015 at 04:50:35PM +0300, Roman Kagan wrote:
> +fake_virtio_win_dir = fake-virtio-win
> +FAKE_VIRTIO_WIN = $(wildcard $(fake_virtio_win_dir)/*/*/*/*)
Why the fake_virtio_win_dir variable? Unfortunately automake treats
variables that have '*dir' in the name specially, but in this case I
don't think you intended that.
Absolutely not. I'm basically uninitiated in auto-foo and had no idea
this could mean anything special to automake; I just needed a simple
make variable. I've checked that it propagated as I expected into
Makefile.in and then into Makefile, and that looked like enough to me.
BTW patch 1 introduces fake_virt_tools_dir which probably has the same
concern, doesn't it?
Roman.