Re: [Libguestfs] [PATCH 1/2] inspect: fstab: Canonicalize paths appearing in fstab.

This implementation looks a bit inefficient to me (recursive, moving

bytes and using strlen for every char removed, etc). What about the following implementation? void canonicalize(char *s) { size_t len = strlen(s); char *orig = s; s = strchr(s, '/'); while (s != NULL && *s != 0) { char *pos = s + 1; char *p = pos; while (*p == '/') ++p; if (p - pos > 0) { memmove(pos, p, len - (p - orig) + 1); len -= p - pos; } s = strchr(pos, '/'); } orig[len] = 0; } The only behaviour change with the committed implementation is that it does not remove trailing slashes, but IMHO they could be left there (or removed after the canonicalization function, just once).