On Friday, 23 March 2018 15:30:38 CET Richard W.M. Jones wrote:
On Fri, Mar 23, 2018 at 12:35:36PM +0100, Pino Toscano wrote:
> So far v2v did not read the model of network interfaces, resulting in
> "virtio" as the model for such interfaces.
>
> Start reading the model, if available, mapping only E1000 for now.
Looks sensible, ACK.
> There are also other models, e.g. PCNet32 or VmxNet3, but they are
> ignored for now: reading them as Source_other_nic would result in v2v
> rejecting OVAs previously converted.
-i vmx and -i libvirt(xml) does parse them as Source_other_nic. Apart
from rcaps_from_source which is only used by --in-place conversions
the NIC model is basically ignored everywhere. So I think it would be
safe to modify this patch to map them to Source_other_nic unless I've
missed something else.
No, what you said sums up everything. I will change this patch to parse
them as Source_other_nic (lowercase), and push it.
Thanks,
--
Pino Toscano