Re: [Libguestfs] [PATCH nbdkit v2] common: Move shared bitmap code to a common library.
On Mon, Dec 03, 2018 at 03:00:22PM -0600, Eric Blake wrote:
>+
>+ bm->bitmap[blk_offset] |= v << blk_bit;
Do you want to mask out the existing bits first, or is this
intentionally only a saturating set (where you can turn bits on but
not off)? Should there be a counterpart for clearing bits?
Yes this is actually wrong - it should as you say mask out existing
bits first. It's also wrong in the existing code, which makes me
wonder if we are just lucky about the order in which states can
transition in the cache plugin.
Anyway I will fix this and other things in the next version.
Thanks,
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top