Re: [Libguestfs] [PATCH nbdkit] Add support for writing plugins in Rust.

On 2/8/19 5:55 AM, Richard W.M. Jones wrote: I'm just now noticing, but this may need further changes to be VPATH-friendly. 'make distcheck' fails with: make[4]: Entering directory '/home/eblake/nbdkit/nbdkit-1.13.1/_build/sub/plugins/rust' cargo build --release error: failed to parse manifest at `/home/eblake/nbdkit/nbdkit-1.13.1/_build/sub/plugins/rust/Cargo.toml` Caused by: no targets specified in the manifest either src/lib.rs, src/main.rs, a [lib] section, or [[bin]] section must be present make[4]: *** [Makefile:682: target/release/libnbdkit.rlib] Error 101 make[4]: Leaving directory '/home/eblake/nbdkit/nbdkit-1.13.1/_build/sub/plugins/rust' [Note that make distcheck fails for other reasons as well, such as the fact that pkg-config gives results for bash-completion that tries to install into the live system rather than honoring --prefix. I've had threads on that in the past; those other failures later in the 'make distcheck' sequence mean we can't completely rely on it to ensure our package is self-contained and VPATH friendly, but it does help in catching some obvious problems even with those known failures] -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org