Re: [Libguestfs] [v2v PATCH 8/9] convert/libosinfo_utils: introduce "os_support_of_osinfo_device_list"
On 01/06/22 16:06, Richard W.M. Jones wrote:
On Thu, Jan 06, 2022 at 03:09:09PM +0100, Laszlo Ersek wrote:
> + | { q35; vio10 }, { Libosinfo.id } :: tail ->
> + let q35 = q35 || id = "http://qemu.org/chipset/x86/q35"
> + and vio10 = vio10 || id = "http://pcisig.com/pci/1af4/1041"
> + in
As a matter of style we usually put "in" on its own line only after a
function definition. In this case it's defining a non-function so I'd
put the "in" at the end of the previous line.
Patch looks fine otherwise so ACK
Will fix up, and thanks!
Laszlo