On Mon, Jun 29, 2015 at 07:17:04PM +0200, Pino Toscano wrote:
In data giovedì 25 giugno 2015 15:56:53, Richard W.M. Jones ha
scritto:
> If you've ever tried to use this option, you'll know that it didn't
> work well. It broke random things (probably RHBZ#1020216, definitely
> RHBZ#1023630), and caused random failures generally, while often not
> actually failing when valgrind itself found problems.
>
> This does not remove the guestfs_internal_exit API. That will
> instead be modified in a future commit.
> ---
I understand you don't like how it is currently done (and I might
agree); OTOH, some of the stuff here could still be used when trying to
valgrind the daemon within the appliance. Can you please leave this
commit aside for now, while I'm expermenting with a simplier valgrind
mode for the daemon?
OK, but it's likely to break (more) because a subsequent patch
changes the behaviour of internal_exit slightly.
Rich.
--
Richard Jones, Virtualization Group, Red Hat
http://people.redhat.com/~rjones
Read my programming and virtualization blog:
http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW