[Libguestfs] [PATCH] daemon: Set O_CLOEXEC flag on the virtio-serial port.

You can see that currently we leak the virtio-serial file descriptor into child processes. 0 /dev/console 1 /dev/console 2 /dev/console 3 /dev/vport0p1 4 /proc/252/fd total 0 lr-x------ 1 root root 64 Aug 27 15:14 0 -> /dev/null l-wx------ 1 root root 64 Aug 27 15:14 1 -> pipe:[5124] l-wx------ 1 root root 64 Aug 27 15:14 2 -> pipe:[5124] lrwx------ 1 root root 64 Aug 27 15:14 3 -> /dev/vport0p1 lr-x------ 1 root root 64 Aug 27 15:14 4 -> /proc/271/fd The attached patch fixes this by setting close-on-exec. I'm using O_CLOEXEC which will only work with relatively recent versions of Linux. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top