Re: [Libguestfs] [PATCH libnbd v2 1/2] golang: Changes test license to LPGL
On Sun, Oct 31, 2021 at 06:20:05PM +0000, Richard W.M. Jones wrote:
On Sun, Oct 31, 2021 at 06:59:32PM +0200, Nir Soffer wrote:
> Having different license for the tests complicates everyone life for no
> benefit. Change the license to LGPL2+ like the rest of the library.
>
> Related discussion:
> https://listman.redhat.com/archives/libguestfs/2021-October/msg00196.html
>
> Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
I agree with this change.
Since this involves some code that I wrote originally, can you add:
Signed-off-by: Richard W.M. Jones <rjones(a)redhat.com>
However I'm not the only author here (by quite a lot!):
$ git shortlog -s golang/src/libguestfs.org/libnbd/
13 Eric Blake
2 Nir Soffer
4 Richard W.M. Jones
so could be a good idea to ask Eric specifically for permission too
(even though in both cases the © is likely assigned to Red Hat as our
employer).
Looking at libnbd.git as a whole I see
1 Author: anson <83398016+anson-lo(a)users.noreply.github.com>
1 Author: Chris Lamb <lamby(a)debian.org>
324 Author: Eric Blake <eblake(a)redhat.com>
1 Author: Laszlo Ersek <lersek(a)redhat.com>
52 Author: Martin Kletzander <mkletzan(a)redhat.com>
5 Author: Nir Soffer <nirsof(a)gmail.com>
33 Author: Nir Soffer <nsoffer(a)redhat.com>
2 Author: Pino Toscano <ptoscano(a)redhat.com>
936 Author: Richard W.M. Jones <rjones(a)redhat.com>
only two patches from non-Red Hat people, and both of those patches
are trivial bug fixes so could be said to be non-copyrigtable changes.
With this in mind, I would suggest that it is viable to remove all the
license headers across the codebase and add SPDX tags in their place.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|