Re: [Libguestfs] [PATCH] builder: better handle some index parsing errors
On Wed, Apr 02, 2014 at 06:13:59PM +0200, Pino Toscano wrote:
Add a new lexer token, unused in the grammar, for the unknown lines
in
index files; this should allow to better handle such kind of parsing
errors, removing the need to exit() directly (and leave things in an
unclean state).
Seems OK, but is the patch incomplete? Should something in the parser
handle the new symbol by displaying a better error?
While looking at this I realized that we didn't have any tests of the
parser. See the patch I just posted.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW